Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs in baseline resync #236

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Fix some bugs in baseline resync #236

merged 9 commits into from
Dec 9, 2024

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Dec 3, 2024 •
edited
Loading

This PR should be merged after eBay/HomeStore#596

Add pg_size and chunk_size in the pg data mesg to avoid inconsistency.

@koujl
Copy link

koujl commented Dec 3, 2024

This PR should be merged after eBay/HomeStore#596

Let's update the dependency constraint in conanfile.py to explicitly specify this homestore version requirement.

@Besroy
add current leader if error is NOT_LEADER (eBay#237)
5398f92 
Co-authored-by: yawzhang <yawzhang@ebay.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 26.31579% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (baseline_resync@2726477). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 0.00% 26 Missing ⚠️
src/lib/homestore_backend/hs_blob_manager.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                Coverage Diff                 @@
##             baseline_resync     #236   +/-   ##
==================================================
  Coverage                   ?   65.52%           
==================================================
  Files                      ?       33           
  Lines                      ?     2271           
  Branches                   ?      254           
==================================================
  Hits                       ?     1488           
  Misses                     ?      659           
  Partials                   ?      124

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuwmao
Copy link
Contributor Author

yuwmao commented Dec 4, 2024

This PR should be merged after eBay/HomeStore#596

Let's update the dependency constraint in conanfile.py to explicitly specify this homestore version requirement.

Ok, fix it to 6.5.19.

@yuwmao yuwmao force-pushed the baseline_resync branch 2 times, most recently from 3b74dd6 to e5a7949 Compare December 4, 2024 09:46
xiaoxichen and others added 2 commits December 6, 2024 14:09
@xiaoxichen
Add num_disks into stat
b8334df 
Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@yuwmao
Fix some bugs in baseline_resync
fd081cc
yuwmao and others added 3 commits December 9, 2024 16:41
@yuwmao
Update conanfile
fd8e51f
@xiaoxichen
Adopt on_repl_devs_init_completed CB.
c8cbe36 
moving PG/Shard recovery into this CB, through
HomeObject::on_replica_restart().

Stop calling on_replica_restart from StateMachine::on_restart().

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@yuwmao
Merge branch 'main' into baseline_main
55efbde
@koujl koujl merged commit 1f5b242 into eBay:baseline_resync Dec 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koujl koujl koujl approved these changes

@xiaoxichen xiaoxichen Awaiting requested review from xiaoxichen

@JacksonYao287 JacksonYao287 Awaiting requested review from JacksonYao287

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuwmao @koujl @codecov-commenter @Besroy @xiaoxichen