Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking received data size and reject if not match. #586

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

xiaoxichen
Copy link
Collaborator

We dont need to panic in this case, fetchData can handle this.

We dont need to panic in this case, fetchData can handle this.

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.25%. Comparing base (1a0cef8) to head (88d80c8).
Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 0.00% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #586       +/-   ##
===========================================
+ Coverage   56.51%   67.25%   +10.73%     
===========================================
  Files         108      109        +1     
  Lines       10300    10734      +434     
  Branches     1402     1470       +68     
===========================================
+ Hits         5821     7219     +1398     
+ Misses       3894     2817     -1077     
- Partials      585      698      +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xiaoxichen xiaoxichen merged commit f83679a into eBay:master Nov 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants