Log iterator should not return records already flushed #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
greensky00
commented
Dec 19, 2023
greensky00
commented
- Log iterator should not return records whose sequence number is smaller than the last flushed one. Otherwise, it may result in returning stale data, especially when the old data still resides in the log file while the flushed data is already compacted and removed from table file.
* Log iterator should not return records whose sequence number is smaller than the last flushed one. Otherwise, it may result in returning stale data, especially when the old data still resides in the log file while the flushed data is already compacted and removed from table file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.