Skip to content

Commit

Permalink
Addressing comments regarding member variable names.
Browse files Browse the repository at this point in the history
  • Loading branch information
byarger-ebay committed Aug 17, 2023
1 parent f0bba68 commit a414b16
Show file tree
Hide file tree
Showing 10 changed files with 30 additions and 30 deletions.
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPBooleanCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class JPBooleanCheck implements JsonPathExecutor, NullCheck<JPBooleanChec
private static final long serialVersionUID = 888395578771081432L;

private Boolean expectedValue = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run the baseline checks for a boolean - not null.
Expand Down Expand Up @@ -47,13 +47,13 @@ public Boolean getExpectedValue() {

@Override
public JPBooleanCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPDoubleCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class JPDoubleCheck implements JsonPathExecutor, NullCheck<JPDoubleCheck>
private static final long serialVersionUID = -202076040776990133L;

private Double expectedValue = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run the baseline checks for a double - not null.
Expand Down Expand Up @@ -47,13 +47,13 @@ public Double getExpectedValue() {

@Override
public JPDoubleCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPIntegerCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class JPIntegerCheck implements JsonPathExecutor, NullCheck<JPIntegerChec
private static final long serialVersionUID = 5372890880704649745L;

private Integer expectedValue = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run the baseline checks for an integer - not null.
Expand Down Expand Up @@ -47,13 +47,13 @@ public Integer getExpectedValue() {

@Override
public JPIntegerCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPJsonArrayCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class JPJsonArrayCheck implements JsonPathExecutor, NullCheck<JPJsonArray
private Integer minLength;

private Integer maxLength;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Set the exact length the JSON array should have.
Expand Down Expand Up @@ -88,13 +88,13 @@ public Integer getMaxLength() {

@Override
public JPJsonArrayCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPJsonObjectCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class JPJsonObjectCheck implements JsonPathExecutor, NullCheck<JPJsonObje
private LinkedHashMap<String, Object> expectedMap = null;
private HashMap<String, Object> containsMap = null;
private List<String> doesNotContainKeys = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Make sure the object has the specified number of keys.
Expand Down Expand Up @@ -155,13 +155,13 @@ public List<String> getDoesNotContainKeys() {

@Override
public JPJsonObjectCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@SuppressWarnings("unlikely-arg-type")
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPListOfBooleanCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class JPListOfBooleanCheck implements JsonPathExecutor, NullCheck<JPListO
private List<Boolean> containsValues = null;

private Boolean allExpectedValue = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run baseline checks for a list of Booleans - list is not null and indexes
Expand Down Expand Up @@ -177,13 +177,13 @@ public Boolean getAllExpectedValue() {

@Override
public JPListOfBooleanCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPListOfDoubleCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class JPListOfDoubleCheck implements JsonPathExecutor, NullCheck<JPListOf
private List<Double> containsValues = null;

private Double allExpectedValue = null;
private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run baseline checks for a list of Doubles - list is not null and indexes
Expand Down Expand Up @@ -177,13 +177,13 @@ public Double getAllExpectedValue() {

@Override
public JPListOfDoubleCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPListOfIntegerCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class JPListOfIntegerCheck implements JsonPathExecutor, NullCheck<JPListO

private Integer allExpectedValue = null;

private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run baseline checks for a list of Integers - list is not null and indexes
Expand Down Expand Up @@ -179,13 +179,13 @@ public Integer getAllExpectedValue() {

@Override
public JPListOfIntegerCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPListOfStringCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class JPListOfStringCheck implements JsonPathExecutor, NullCheck<JPListOf

private List<String> limitedToValues = null;

private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run baseline checks for a list of strings - list is not null and indexes
Expand Down Expand Up @@ -207,13 +207,13 @@ public String getAllExpectedValue() {

@Override
public JPListOfStringCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions NST/src/main/java/com/ebay/jsonpath/JPStringCheck.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class JPStringCheck implements JsonPathExecutor, NullCheck<JPStringCheck>

private Integer maximumNumberOfCharacters = null;

private boolean isNull = false;
private boolean nullExpected = false;

/**
* Run the baseline checks for a String - not null and not empty.
Expand Down Expand Up @@ -182,13 +182,13 @@ public String getMatchesPattern() {

@Override
public JPStringCheck checkIsNull(boolean mustBeNull) {
isNull = mustBeNull;
nullExpected = mustBeNull;
return this;
}

@Override
public boolean isNullExpected() {
return isNull;
return nullExpected;
}

@Override
Expand Down

0 comments on commit a414b16

Please sign in to comment.