Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EbayDetails): Add new EbayDetails component #399

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

HenriqueLimas
Copy link
Member

Description

  • Add new EbayDetails component, following ebayui-core implementation
  • Upgrade user-event to latest variable so it triggers the toggle event on clicking of the details
  • Updated tests to use the new user-event version that uses async

The EbayDetails is required for the new EbayAccordion component

Note: waiting for #395 to add the changeset

@HenriqueLimas HenriqueLimas added this to the 8.0.0 milestone Jan 14, 2025
@HenriqueLimas HenriqueLimas self-assigned this Jan 14, 2025
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 5fde305

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ui-core-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HenriqueLimas HenriqueLimas marked this pull request as ready for review January 14, 2025 21:21
src/ebay-details/README.md Outdated Show resolved Hide resolved
@HenriqueLimas HenriqueLimas merged commit 44ff1d7 into 8.0.0 Jan 15, 2025
7 checks passed
@HenriqueLimas HenriqueLimas deleted the ebay-details branch January 15, 2025 19:27
@HenriqueLimas HenriqueLimas mentioned this pull request Jan 29, 2025
3 tasks
HenriqueLimas added a commit that referenced this pull request Jan 31, 2025
* feat(EbayDetails): Add new EbayDetails component

* Add changeset

* Fix docs title

---------

Co-authored-by: Timur Manyanov <2737310+darkwebdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants