Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebay-area-chart): Refactor and unignore ebay-area-chart module #2312

Open
wants to merge 11 commits into
base: 14.5.0
Choose a base branch
from

Conversation

mikehobi
Copy link
Contributor

@mikehobi mikehobi commented Nov 1, 2024

Description

  • Un-ignores existing ebay-area-chart component
  • Simplify axis logic
  • Simplify label formatting
  • Allows for custom Highcharts configuration for more custom implementations

Context

Create a reusable donut chart based on DS Data Viz component design

Github issue: #2075

Screenshots

image image image

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 8db700a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikehobi mikehobi changed the base branch from master to 14.5.0 November 5, 2024 18:44
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants