Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdowns): added support for floating-ui #2381

Merged
merged 3 commits into from
Jan 24, 2025
Merged

feat(dropdowns): added support for floating-ui #2381

merged 3 commits into from
Jan 24, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 15, 2025

Description

  • Added floating ui support for all dropdowns
  • Also added it for calendar
  • For combobox, need to retrigger the show attribute on makeup change in case the expander is expanded on rerender
  • For chips combobox there's an issue where we need to attach the dropdown to the root element. For this, passed in a function which resolves to the root elemenet into combobox. This attribute is not supposed to be documented outside of our code.
  • Reverse will be handled by the popper automatically

References

#2349

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 22af2fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga force-pushed the floating-ui branch 2 times, most recently from 00d568e to d30988f Compare January 16, 2025 17:14
@agliga agliga force-pushed the floating-ui branch 2 times, most recently from a920db7 to 4573a98 Compare January 16, 2025 17:29
@agliga agliga self-assigned this Jan 16, 2025
@agliga agliga requested a review from JoshuaWink January 16, 2025 20:13
@agliga agliga force-pushed the 15.0.0 branch 3 times, most recently from 3f319bc to c2b5b9d Compare January 23, 2025 18:32
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, left a few comments

Is there any world where DropdownUtil can be merged with the makeup setup, or does that not make sense?

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor thing.

@agliga
Copy link
Contributor Author

agliga commented Jan 23, 2025

First pass, left a few comments

Is there any world where DropdownUtil can be merged with the makeup setup, or does that not make sense?

Could be a good idea
It would be good to add floating ui to expander but that's outside this.

@agliga
Copy link
Contributor Author

agliga commented Jan 23, 2025

Pr should be ready to re-review

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well, this will simplify the lives of so many people using eBayUI. Just one comment on code I'm confused about, but I think it's good to merge either way

@agliga agliga merged commit 02f0cd8 into 15.0.0 Jan 24, 2025
5 checks passed
@agliga agliga deleted the floating-ui branch January 24, 2025 15:34
This was referenced Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants