-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdowns): added support for floating-ui #2381
Conversation
🦋 Changeset detectedLatest commit: 22af2fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
00d568e
to
d30988f
Compare
a920db7
to
4573a98
Compare
3f319bc
to
c2b5b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, left a few comments
Is there any world where DropdownUtil
can be merged with the makeup setup, or does that not make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor thing.
Could be a good idea |
Pr should be ready to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well, this will simplify the lives of so many people using eBayUI. Just one comment on code I'm confused about, but I think it's good to merge either way
Description
References
#2349