Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renamed drawer and fullscreen to be deprecated #2411

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 27, 2025

Description

Renamed ebay-drawer-dialog to ebay-drawer-dialog-deprecated and ebay-fullscreen-dialog to ebay-fullscreen-dialog-deprecated

Screenshots

Screenshot 2025-01-27 at 1 11 35 PM

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 2948a3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny nitpick— I think it might be better to put deprecated first instead of last so it's super clear. Maybe even yell with something like <DEPRECATED-ebay-drawer-dialog>

Regardless I think this is good to merge

```

** Deprecated ** (Use lightbox-dialog instead)
** Deprecated will be removed next major ** (Use lightbox-dialog instead)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To render Deprecated in bold the spaces need to be removed between ** character. Like **Deprecated ... major**

@agliga agliga merged commit 57d2b60 into 15.0.0 Jan 29, 2025
5 checks passed
@agliga agliga deleted the deprecated-components branch January 29, 2025 16:16
This was referenced Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants