Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marko-json): changed all attribute tags to be singular #2415

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 30, 2025

Description

  • Changed all marko attribute tags to be singular
    Original change done by @WinkeeFace, just mainly fixed tests and merge conflicts with this

References

#2165

@agliga agliga requested a review from LuLaValva January 30, 2025 16:50
@agliga agliga self-assigned this Jan 30, 2025
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 1fd20b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @agliga! Just a few minor comments, and then I'll do one more pass

@agliga
Copy link
Contributor Author

agliga commented Jan 30, 2025

Done, should be ready for re-review

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @agliga and @WinkeeFace!

@agliga agliga merged commit 02f4e69 into 15.0.0 Jan 30, 2025
5 checks passed
@agliga agliga deleted the marko-json branch January 30, 2025 21:57
This was referenced Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants