Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textbox): added check to show prefix label only if floating is not set #2426

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat(textbox): added check to show prefix label only if floating is not set #2426

merged 1 commit into from
Feb 12, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Feb 10, 2025

Description

  • Since prefix label cannot be used with floating label (because there are overrides), we have disabled it for now.
  • For static floating label, we enable it (since it will always be floated and not overlap, such as in phone textbox.

References

#2373

@agliga agliga self-assigned this Feb 10, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 539a2c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga changed the base branch from master to 15.1.0 February 10, 2025 19:11
ArtBlue
ArtBlue approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great change!

@agliga agliga merged commit ac954a8 into 15.1.0 Feb 12, 2025
5 checks passed
@agliga agliga deleted the floating-label-prefix branch February 12, 2025 18:54
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Closed
This was referenced Feb 24, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtBlue ArtBlue ArtBlue approved these changes

@HenriqueLimas HenriqueLimas Awaiting requested review from HenriqueLimas

@saiponnada saiponnada Awaiting requested review from saiponnada

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

Assignees

@agliga agliga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agliga @ArtBlue