Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(section-title): removed tabindex=-1 and aria-hidden from anchor tag #2429

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Feb 12, 2025

Description

  • Removed tabindex and aria hidden from anchor tag.

References

#2427

Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 65aa647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One minor doc change as part of section-title scope.

  • Add aria-label on icon button for save-see-all.marko story.

@agliga
Copy link
Contributor Author

agliga commented Feb 14, 2025

LGTM!

One minor doc change as part of section-title scope.

  • Add aria-label on icon button for save-see-all.marko story.

That's a different issue than this PR. I will add it, but lets make sure we don't scope creep

@saiponnada saiponnada self-requested a review February 14, 2025 18:05
@ArtBlue ArtBlue merged commit d929e04 into 15.1.0 Feb 19, 2025
5 checks passed
@ArtBlue ArtBlue deleted the section-title branch February 19, 2025 21:35
This was referenced Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants