feat(avatar): added image position option

[agliga]

Description

• Added image position option
• Options are fit, contain and auto. Auto detects aspect ratio and sets fit or contain.

References

#2434

Screenshots

[changeset-bot]

🦋 Changeset detected

Latest commit: 28142af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@ebay/ebayui-core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[LuLaValva]

Mostly looks good, but philosophical question— why do we allow users to use anything besides "auto"? Shouldn't avatar look the same everywhere? I understand it's more overhead on the client if an app team already had information about the aspect ratio of the image, but I'm not sure that's worth accounting for.

[agliga]

Mostly looks good, but philosophical question— why do we allow users to use anything besides "auto"? Shouldn't avatar look the same everywhere? I understand it's more overhead on the client if an app team already had information about the aspect ratio of the image, but I'm not sure that's worth accounting for.

I only set it like this because if you can detect the dimensions on the server you should set it there.

Also i set cover as default so it doesnt break but we can change it to auto as default if needed.

[LuLaValva]

I only set it like this because if you can detect the dimensions on the server you should set it there.

I don't think we should add the option to set it from the backend. We don't have clear documentation on the specific aspect ratio where it switches from "fit" to "cover", and if it ever changes then a bunch of apps will be out of sync

[agliga]

From design
It should be
3:4 aspect ratio or 4:3 aspect ration and square (1/1) to be center
All others fit. If there is an irregular aspect ratio it should also be fit.
This isnt taking square into account. Or its allowing more than it should.

[LuLaValva]

All others fit. If there is an irregular aspect ratio it should also be fit.

I will talk to a designer, but I don't think that's right. My understanding is that everything between 4:3 and 3:4 should be "fill", based on this part of playbook:

Crops narrower than a 4:3 aspect ratio, such as 16:9 or more extreme formats, are adjusted to “fit.”