Fix type of create function for interfaces #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hit with interesting type of regression after updating lib from version 1.2.8
After some investigation I found, that interface are not legal extension of Record<string, unknown>, and this is by design (per microsoft/TypeScript#15300 (comment)), since they are potential target of interface merge
Since I don't see any real improvement over
P extends {}
I thought it would be better to revert this particular change