Remove LRU cashe for invalid tokens #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2024 11:33
…U cache for tokens and always verify them using jwt library
sbinmalek
reviewed
May 23, 2024
raakella1
force-pushed
the
remove_lru_token
branch
from
d8e46b9
to
51f77d7
Compare
raakella1
changed the title
jiankyu
reviewed
May 23, 2024
| bool access_token_expired() const { | ||
| return (std::chrono::system_clock::now() > | ||
| m_expiry + std::chrono::seconds(SECURITY_DYNAMIC_CONFIG(auth_manager->leeway))); | ||
| m_expiry - std::chrono::seconds(SECURITY_DYNAMIC_CONFIG(trf_client->trf_expiry_leeway_secs))); |
There was a problem hiding this comment.
If the library verify() already covers the timestamp check, do we need to check it one more time here? I mean, should we still need this "access_token_expired()" method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix token expired issue due to time drift in issued_at claim,, more info https://jirap.corp.ebay.com/browse/SDSTOR-13615?filter=-1
Do not cache invalid tokens. Add leeways for issued_at and not_before claims as an optimization.
Also, add leeway to trf client to download token ahead of its expiry.