Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release with updates #76

Merged
merged 3 commits into from
Aug 8, 2015
Merged

New release with updates #76

merged 3 commits into from
Aug 8, 2015

Conversation

sielaq
Copy link
Contributor

@sielaq sielaq commented Aug 8, 2015

sielaq added a commit that referenced this pull request Aug 8, 2015
@sielaq
Merge pull request #76 from sielaq/master
93603aa 
New release with updates
@sielaq sielaq merged commit 93603aa into eBayClassifiedsGroup:master Aug 8, 2015
@Kosta-Github
Copy link
Contributor

@sielaq Thanks for the updates.

You are using the KEEPALIVED_VIP env variable for the HAProxy restart tweaks, but my keepalived PR (#68) hasn't been merged yet. Do you plan to pull that in anytime soon? I updated the PR with your latest changes and now keepalived works well with your haproxy_a and haproxy_b ping-pong...

@sielaq
Copy link
Contributor Author

sielaq commented Aug 10, 2015

I just added it for you so you can test HA proxy reload. I'm still not fine with that solution. The final solution we would like to kick out HAproxy and consul-template and start using new proxy/router but I can't wait till our policy allow us to OpenSource code which was closed.

@Kosta-Github
Copy link
Contributor

OK, thanks for the preliminary keepalived enabled support then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sielaq @Kosta-Github