Skip to content

Commit

Permalink
Minimal Repro: MedieElement fails on HTTPS
Browse files Browse the repository at this point in the history
When `MediaElement.Source` is set to a HTTPS-Uri
- .NET 4.8 Project throws `NullReferenceException`
   at System.Windows.Media.MediaPlayerState.OpenMedia(Uri source)
   at System.Windows.Media.MediaPlayerState.SetSource(Uri source)
   at System.Windows.Media.MediaPlayerState.Open(Uri source)
- .NET Core 5.0 Application sucessfully plays the Source.

Plain HTTP works in both runtimes.

See
https://stackoverflow.com/questions/30702505/playing-media-from-https-site-in-media-element-throwing-null-reference-exception
dotnet/wpf#722
fixed and merged with dotnet/wpf#969
into .NET Core.
  • Loading branch information
FloH committed Jan 11, 2022
1 parent 25f36b9 commit 0e97cc4
Show file tree
Hide file tree
Showing 14 changed files with 424 additions and 2 deletions.
9 changes: 9 additions & 0 deletions InternetRadio.Core/App.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Application x:Class="InternetRadio.Core.App"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:local="clr-namespace:InternetRadio.Core"
StartupUri="MainWindow.xaml">
<Application.Resources>

</Application.Resources>
</Application>
17 changes: 17 additions & 0 deletions InternetRadio.Core/App.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using System;
using System.Collections.Generic;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Threading.Tasks;
using System.Windows;

namespace InternetRadio.Core
{
/// <summary>
/// Interaction logic for App.xaml
/// </summary>
public partial class App : Application
{
}
}
10 changes: 10 additions & 0 deletions InternetRadio.Core/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
using System.Windows;

[assembly: ThemeInfo(
ResourceDictionaryLocation.None, //where theme specific resource dictionaries are located
//(used if a resource is not found in the page,
// or application resource dictionaries)
ResourceDictionaryLocation.SourceAssembly //where the generic resource dictionary is located
//(used if a resource is not found in the page,
// app, or any theme specific resource dictionaries)
)]
9 changes: 9 additions & 0 deletions InternetRadio.Core/InternetRadio.Core.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFramework>net5.0-windows</TargetFramework>
<UseWPF>true</UseWPF>
</PropertyGroup>

</Project>
35 changes: 35 additions & 0 deletions InternetRadio.Core/MainWindow.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<Window x:Class="InternetRadio.Core.MainWindow"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:local="clr-namespace:InternetRadio.Core"
mc:Ignorable="d"
Title="InternetRadio .NET Core 5.0" Height="450" Width="800">
<Grid>
<Grid.RowDefinitions>
<RowDefinition Height="*" />
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>
<MediaElement
Grid.Row="0"
x:Name="Player" />
<Button
Grid.Row="1"
MinHeight="48"
MinWidth="120"
Click="ButtonPlay_Click"
CommandParameter="http://f121.rndfnk.com/ard/wdr/wdr2/ruhrgebiet/mp3/128/stream.mp3?sid=23Z0wY47oF8hORZdsB0UmK4LpvD&amp;token=KUVrBgGUy3s2hZbnmellq1IsTH2ntDS1cQqx9GX8XAA&amp;tvf=Y8P2ZiJfyRZmMTIxLnJuZGZuay5jb20"
Content="Play HTTP"
/>
<Button
Grid.Row="2"
MinHeight="48"
MinWidth="120"
Click="ButtonPlay_Click"
CommandParameter="https://d111.rndfnk.com/ard/swr/swr3/live/mp3/128/stream.mp3?aggregator=web&amp;sid=23Z0z3SG4a5H50EauA99PgFHodV&amp;token=kOobYcOaJGxSrOP7EHLzrrWw1fb0-5OI9sneQUuFf6Q&amp;tvf=lnPQ9iZfyRZkMTExLnJuZGZuay5jb20"
Content="Play HTTPS"
/>
</Grid>
</Window>
55 changes: 55 additions & 0 deletions InternetRadio.Core/MainWindow.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Data;
using System.Windows.Documents;
using System.Windows.Input;
using System.Windows.Media;
using System.Windows.Media.Imaging;
using System.Windows.Navigation;
using System.Windows.Shapes;

namespace InternetRadio.Core
{
/// <summary>
/// Interaction logic for MainWindow.xaml
/// </summary>
public partial class MainWindow : Window
{
public MainWindow()
{
InitializeComponent();
this.Player.LoadedBehavior = MediaState.Manual;
this.Player.UnloadedBehavior = MediaState.Manual;
}

private void ButtonPlay_Click(object sender, RoutedEventArgs e)
{
this.Player.Stop();
this.Player.Position = TimeSpan.Zero;

try
{
string source = ((Button)sender).CommandParameter as string;
this.Player.Source = new Uri(source, UriKind.Absolute);
}
catch (Exception ex)
{
MessageBox.Show("Player.Play:\n" + ex);
}

try
{
this.Player.Play();
}
catch (Exception ex)
{
MessageBox.Show("Player.Play:\n" + ex);
}
}
}
}
6 changes: 6 additions & 0 deletions InternetRadio.Net48/App.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8" />
</startup>
</configuration>
9 changes: 9 additions & 0 deletions InternetRadio.Net48/App.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Application x:Class="InternetRadio.Net48.App"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:local="clr-namespace:InternetRadio.Net48"
StartupUri="MainWindow.xaml">
<Application.Resources>

</Application.Resources>
</Application>
17 changes: 17 additions & 0 deletions InternetRadio.Net48/App.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using System;
using System.Collections.Generic;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Threading.Tasks;
using System.Windows;

namespace InternetRadio.Net48
{
/// <summary>
/// Interaction logic for App.xaml
/// </summary>
public partial class App : Application
{
}
}
81 changes: 81 additions & 0 deletions InternetRadio.Net48/InternetRadio.Net48.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<ProjectGuid>{64A8A576-40FB-4810-8304-B3A64BBD445F}</ProjectGuid>
<OutputType>WinExe</OutputType>
<RootNamespace>InternetRadio.Net48</RootNamespace>
<AssemblyName>InternetRadio.Net48</AssemblyName>
<TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WarningLevel>4</WarningLevel>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<Deterministic>true</Deterministic>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<OutputPath>bin\Release\</OutputPath>
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Core" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="System.Net.Http" />
<Reference Include="System.Xaml">
<RequiredTargetFramework>4.0</RequiredTargetFramework>
</Reference>
<Reference Include="WindowsBase" />
<Reference Include="PresentationCore" />
<Reference Include="PresentationFramework" />
</ItemGroup>
<ItemGroup>
<ApplicationDefinition Include="App.xaml">
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</ApplicationDefinition>
<Compile Include="App.xaml.cs">
<DependentUpon>App.xaml</DependentUpon>
<SubType>Code</SubType>
</Compile>
</ItemGroup>
<ItemGroup>
<Compile Include="MainWindow.xaml.cs">
<DependentUpon>MainWindow.xaml</DependentUpon>
</Compile>
<Compile Include="Properties\AssemblyInfo.cs">
<SubType>Code</SubType>
</Compile>
</ItemGroup>
<ItemGroup>
<None Include="App.config" />
</ItemGroup>
<ItemGroup>
<Page Include="MainWindow.xaml">
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>
35 changes: 35 additions & 0 deletions InternetRadio.Net48/MainWindow.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<Window x:Class="InternetRadio.Net48.MainWindow"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:local="clr-namespace:InternetRadio.Net48"
mc:Ignorable="d"
Title="InternetRadio .NET 4.8" Height="450" Width="800">
<Grid>
<Grid.RowDefinitions>
<RowDefinition Height="*" />
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>
<MediaElement
Grid.Row="0"
x:Name="Player" />
<Button
Grid.Row="1"
MinHeight="48"
MinWidth="120"
Click="ButtonPlay_Click"
CommandParameter="http://f121.rndfnk.com/ard/wdr/wdr2/ruhrgebiet/mp3/128/stream.mp3?sid=23Z0wY47oF8hORZdsB0UmK4LpvD&amp;token=KUVrBgGUy3s2hZbnmellq1IsTH2ntDS1cQqx9GX8XAA&amp;tvf=Y8P2ZiJfyRZmMTIxLnJuZGZuay5jb20"
Content="Play HTTP"
/>
<Button
Grid.Row="2"
MinHeight="48"
MinWidth="120"
Click="ButtonPlay_Click"
CommandParameter="https://d111.rndfnk.com/ard/swr/swr3/live/mp3/128/stream.mp3?aggregator=web&amp;sid=23Z0z3SG4a5H50EauA99PgFHodV&amp;token=kOobYcOaJGxSrOP7EHLzrrWw1fb0-5OI9sneQUuFf6Q&amp;tvf=lnPQ9iZfyRZkMTExLnJuZGZuay5jb20"
Content="Play HTTPS"
/>
</Grid>
</Window>
55 changes: 55 additions & 0 deletions InternetRadio.Net48/MainWindow.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Data;
using System.Windows.Documents;
using System.Windows.Input;
using System.Windows.Media;
using System.Windows.Media.Imaging;
using System.Windows.Navigation;
using System.Windows.Shapes;

namespace InternetRadio.Net48
{
/// <summary>
/// Interaction logic for MainWindow.xaml
/// </summary>
public partial class MainWindow : Window
{
public MainWindow()
{
InitializeComponent();
this.Player.LoadedBehavior = MediaState.Manual;
this.Player.UnloadedBehavior = MediaState.Manual;
}

private void ButtonPlay_Click(object sender, RoutedEventArgs e)
{
this.Player.Stop();
this.Player.Position = TimeSpan.Zero;

try
{
string source = ((Button)sender).CommandParameter as string;
this.Player.Source = new Uri(source, UriKind.Absolute);
}
catch (Exception ex)
{
MessageBox.Show("Player.Play:\n" + ex);
}

try
{
this.Player.Play();
}
catch (Exception ex)
{
MessageBox.Show("Player.Play:\n" + ex);
}
}
}
}
Loading

0 comments on commit 0e97cc4

Please sign in to comment.