Skip to content

Commit

Permalink
fix(build): Don't build on iojs due to node-gyp compat problems
Browse files Browse the repository at this point in the history
See nodejs/node#433 for more details Since
iojs and node are going to merge eventually, this won't be a problem for
too long..
  • Loading branch information
rmehner committed Jun 9, 2015
1 parent c7d38dc commit 8e87988
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
language: node_js
node_js:
- iojs-v2
- iojs-v1
- '0.10'
- '0.12'
cache:
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ Grunt tasks to download translations and upload resources to [Transifex](https:/

## Requirements

* node.js `>= 0.10.x` or io.js `>= 1.0.0`
* node.js `>= 0.10.x`
* io.js should work as well, we only have to wait for [node-gyp to be compatible](https://github.com/nodejs/io.js/issues/433) (or for the eventual node/io merge)
* grunt `~0.4.5`

## Getting started
Expand Down

2 comments on commit 8e87988

@gagern
Copy link

@gagern gagern commented on 8e87988 Jul 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you drop the npm i -g npm@^2.0.0 at least for the iojs case, you should be good. That's what I just did in gagern/libxmljs@0e7416a.

@rmehner
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagern thank you! This has been fixed in #6 already, albeit a little bit different.

Please sign in to comment.