remove jitpack requirement #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mduesterhoeft
suggested changes
Mar 11, 2019
There was a problem hiding this comment.
Hi Kyle,
I am happy to see you back.
Great point. I always wanted the jitpack dependency to go away since we are no longer publishing there. So I am really happy about this information and the PR. Would you mind also updating:
- the README - https://github.com/ePages-de/restdocs-api-spec#build-configuration
- the samples
- https://github.com/ePages-de/restdocs-api-spec/blob/master/samples/restdocs-api-spec-sample/build.gradle#L8
- https://github.com/ePages-de/restdocs-api-spec/blob/master/samples/restdocs-api-spec-sample-web-test-client/build.gradle#L8
|
I tried updating the samples but I don't think I can until after you release a new version without the Jitpack dependency. Similar ly, the README references a specific version that still would require Jitpack so I was hesitant to update it. I'd be happy to open another pull request once the new release is created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason we need the Jitpack repository at this point if for the json-schema package and newer versions of that package are available in maven central. This change should remove the Jitpack requirement which should allow restdocs-api-spec to be pushed to maven central. This will also allow me to push restdocs-spec-maven-plugin to maven central as well which is important for a lot of maven users.