Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URI templates to generate stubs with urlPattern #63

Merged
merged 3 commits into from
Mar 12, 2018

Conversation

mduesterhoeft
Copy link
Contributor

If a URI template is available in the snippet we generate a urlPattern with a regular expression instead of the id in the request. This allows for more flexible request matching when variables are part of the path.

If a URI template is available in the snippet we generate a urlTemplate
with a regular expression instead of the id in the request.
This allows for more flexible request mappings when variables are part of the path.
@coveralls
Copy link

coveralls commented Mar 9, 2018

Coverage Status

Coverage increased (+0.9%) to 94.253% when pulling 478b3d3 on mduesterhoeft:uritemplate into d49e4f2 on ePages-de:master.

@otrosien
Copy link
Contributor

👍

Copy link
Contributor

@otrosien otrosien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@mduesterhoeft mduesterhoeft merged commit bf7a994 into ePages-de:master Mar 12, 2018
@mduesterhoeft mduesterhoeft deleted the uritemplate branch March 12, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants