Update artifact name and compile on Ubuntu 24 (#123)

* Fix artifact name in project_dependencies action Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Add Ubuntu 24.04 and remove Ubuntu 22.04 Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refactor TopicQoS::set_default_qos to use default values directly Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Update versions.md Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Update PLATFORM_SUPPORT Signed-off-by: Irene Bandera <irenebandera@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
eProsima · Jul 18, 2024 · 1402c3a · 1402c3a
1 parent cb8f7e1
commit 1402c3a
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 35 deletions.
diff --git a/.github/actions/project_dependencies/action.yml b/.github/actions/project_dependencies/action.yml
@@ -53,7 +53,7 @@ runs:
  - name: Download dependencies artifact
  uses: eProsima/eProsima-CI/multiplatform/download_dependency@v0
  with:
- artifact_name: built_dev_utils_${{ inputs.custom_version_build }}_${{ inputs.os }}_${{ inputs.cmake_build_type }}${{ inputs.dependencies_artifact_postfix }}
+ artifact_name: build_dev_utils_${{ inputs.custom_version_build }}_${{ inputs.os }}_${{ inputs.cmake_build_type }}${{ inputs.dependencies_artifact_postfix }}
  workflow_source: build_dev_utils.yml
  workflow_source_repository: eProsima/eProsima-CI
  target_workspace: ${{ inputs.target_workspace }}

diff --git a/.github/workflows/reusable-workflow.yml b/.github/workflows/reusable-workflow.yml
@@ -6,7 +6,7 @@
 # - execute tests in different versions of windows with different build types
 #
 # - ubuntu-multiplatform-tests
-# - [ ubuntu-22.04 | ubuntu-20.04 ]
+# - [ ubuntu-22.04 | ubuntu-24.04 ]
 # - [ Debug | Release ]
 # - execute tests in different versions of ubuntu with different build types
 #
@@ -154,8 +154,8 @@ jobs:
  - Release
  - Debug
  os:
- - ubuntu-20.04
  - ubuntu-22.04
+ - ubuntu-24.04
 
  steps:
 

diff --git a/PLATFORM_SUPPORT.md b/PLATFORM_SUPPORT.md
@@ -31,10 +31,10 @@ Community members may provide assistance with these platforms.
 
 ## Platforms
 
-|Architecture|Ubuntu Focal (20.04)|Ubuntu Jammy (22.04)|Windows 10 (VS2019)|Windows 10 (VS2022)|Debian Buster (10)|
+|Architecture|Ubuntu Jammy (22.04)|Ubuntu Noble (24.04)|Windows 10 (VS2019)|Windows 10 (VS2022)|Debian Buster (10)|
 |------------|--------------------|--------------------|-------------------|-------------------|------------------|
 |amd64 |Tier 1 |Tier 1 |Tier 1 |Tier 1 |Tier 3 |
-|arm64 |Tier 3 | | | |Tier 3 |
+|arm64 |  | | | |Tier 3 |
 
 ## Compilers
 

diff --git a/ddspipe_core/include/ddspipe_core/types/dds/TopicQoS.hpp b/ddspipe_core/include/ddspipe_core/types/dds/TopicQoS.hpp
@@ -111,16 +111,7 @@ TopicQoS
  * @brief Set the default Topic QoS.
  */
  DDSPIPE_CORE_DllAPI
- void set_default_qos(
- DurabilityKind durability_qos = DEFAULT_DURABILITY_QOS,
- ReliabilityKind reliability_qos = DEFAULT_RELIABILITY_QOS,
- OwnershipQosPolicyKind ownership_qos = DEFAULT_OWNERSHIP_QOS,
- bool use_partitions = DEFAULT_USE_PARTITIONS,
- bool keyed = DEFAULT_KEYED,
- HistoryDepthType history_depth = DEFAULT_HISTORY_DEPTH,
- float max_tx_rate = DEFAULT_MAX_TX_RATE,
- float max_rx_rate = DEFAULT_MAX_RX_RATE,
- unsigned int downsampling = DEFAULT_DOWNSAMPLING) noexcept;
+ void set_default_qos() noexcept;
 
  /////////////////////////
  // VARIABLES

diff --git a/ddspipe_core/src/cpp/types/dds/TopicQoS.cpp b/ddspipe_core/src/cpp/types/dds/TopicQoS.cpp
@@ -124,27 +124,17 @@ void TopicQoS::set_qos(
  }
 }
 
-void TopicQoS::set_default_qos(
- DurabilityKind durability_qos /*= DEFAULT_DURABILITY_QOS */,
- ReliabilityKind reliability_qos /*= DEFAULT_RELIABILITY_QOS */,
- OwnershipQosPolicyKind ownership_qos /*= DEFAULT_OWNERSHIP_QOS */,
- bool use_partitions /*= DEFAULT_USE_PARTITIONS */,
- bool keyed /*= DEFAULT_KEYED */,
- HistoryDepthType history_depth /*= DEFAULT_HISTORY_DEPTH */,
- float max_tx_rate /*= DEFAULT_MAX_TX_RATE */,
- float max_rx_rate /*= DEFAULT_MAX_RX_RATE */,
- unsigned int downsampling /*= DEFAULT_DOWNSAMPLING */) noexcept
+void TopicQoS::set_default_qos() noexcept
 {
- // The default values must be received as arguments. Otherwise, Ubuntu 20.04 Debug does not compile.
- this->durability_qos.set_value(durability_qos, utils::FuzzyLevelValues::fuzzy_level_default);
- this->reliability_qos.set_value(reliability_qos, utils::FuzzyLevelValues::fuzzy_level_default);
- this->ownership_qos.set_value(ownership_qos, utils::FuzzyLevelValues::fuzzy_level_default);
- this->use_partitions.set_value(use_partitions, utils::FuzzyLevelValues::fuzzy_level_default);
- this->history_depth.set_value(history_depth, utils::FuzzyLevelValues::fuzzy_level_default);
- this->keyed.set_value(keyed, utils::FuzzyLevelValues::fuzzy_level_default);
- this->max_tx_rate.set_value(max_tx_rate, utils::FuzzyLevelValues::fuzzy_level_default);
- this->max_rx_rate.set_value(max_rx_rate, utils::FuzzyLevelValues::fuzzy_level_default);
- this->downsampling.set_value(downsampling, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->durability_qos.set_value(DEFAULT_DURABILITY_QOS, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->reliability_qos.set_value(DEFAULT_RELIABILITY_QOS, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->ownership_qos.set_value(DEFAULT_OWNERSHIP_QOS, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->use_partitions.set_value(DEFAULT_USE_PARTITIONS, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->history_depth.set_value(DEFAULT_HISTORY_DEPTH, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->keyed.set_value(DEFAULT_KEYED, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->max_tx_rate.set_value(DEFAULT_MAX_TX_RATE, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->max_rx_rate.set_value(DEFAULT_MAX_RX_RATE, utils::FuzzyLevelValues::fuzzy_level_default);
+ this->downsampling.set_value(DEFAULT_DOWNSAMPLING, utils::FuzzyLevelValues::fuzzy_level_default);
 }
 
 std::ostream& operator <<(

diff --git a/versions.md b/versions.md
@@ -5,6 +5,10 @@ The *Forthcoming* section includes those features added in `main` branch that ar
 
 ## Forthcoming
 
+The upcoming release will include the following features:
+* Support Ubuntu Noble (24.04).
+* Stop supporting Ubuntu Focal (20.04).
+
 ## eProsima DDS Pipe v0.4.0
 
 This release includes the following *new features*: