Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22329] Serialize single null-character for empty strings #249

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 26, 2024

Description

PR #245 introduced a regression that made nightlies of Fast DDS 2.14.x fail. The serialization of empty strings should consist of a length=1 followed by a single null character.

This adds a regression test and removes the check for empty strings in the serialization code.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.2.6 milestone Nov 26, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit bfa51aa into master Nov 27, 2024
11 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/22284 branch November 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants