Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22341] Fix cmake generator evaluation #251

Merged
merged 1 commit into from
Nov 29, 2024
Merged

[22341] Fix cmake generator evaluation #251

merged 1 commit into from
Nov 29, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 28, 2024 •
edited by MiguelCompany
Loading

Description

This PR adds an extra check before checking checking the target properties. This fix should solve the issue linked in the task.

@Mergifyio backport 1.0.x

Fixes eProsima/Fast-DDS#5283

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@Mario-DL
Refs #22341: Check if target exists before evaluating its properties
bdb0dd6 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v2.2.6 milestone Nov 28, 2024
@Mario-DL Mario-DL changed the title [22341] Check if target exists before evaluating its properties [22341] Fix cmake generator evaluation Nov 28, 2024
@MiguelCompany MiguelCompany self-requested a review November 29, 2024 10:47
MiguelCompany
MiguelCompany approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

@Mergifyio backport 1.0.x

@mergify Mergify
Copy link

mergify bot commented Nov 29, 2024 •
edited
Loading

backport 1.0.x

✅ Backports have been created

@Mario-DL Mario-DL merged commit 0cb11a4 into master Nov 29, 2024
11 checks passed
@Mario-DL Mario-DL deleted the bugfix/22341 branch November 29, 2024 10:58
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@Mario-DL @mergify
Fix cmake generator evaluation (#251)
cd5bf5b 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 0cb11a4)

# Conflicts:
#	src/cpp/CMakeLists.txt
@mergify mergify bot mentioned this pull request Nov 29, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v2.2.6 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.

[22340] Error evaluating generator expression
2 participants
@Mario-DL @MiguelCompany