try to resize when serializing #7
Conversation
|
@wjwwood I was checking the PR. You are trying to resize the buffer in deserialize functions. Why do you need that? Your commit message says you are adding it in serialize functions, but I don't see this in the diff. |
|
Sorry the message should have been deserializing I guess. I was probably meaning that it is needed during "serializing activities", which to me includes both serialization and deserialization. Sorry for the confusion on that part. I can see how this doesn't make sense... In fact, it might have only been necessary to cover up a bug. You'd only want to resize during deserialize if you were asking to extract more data than was in the original octet stream, which shouldn't happen... I think I'll close this and redo my testing without it. However, perhaps these error messages should be something different: In this case, it's not a problem of not enough memory, but more like an out of bounds error, where the deserialization would require more data out of the array than is left. |
|
It seems to work without this pr. Thanks for catching that. |
Like the deserialize functions, try to resize the buffer before giving up on serialization.
Connects to ros2/rmw_fastrtps#36.