Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14485] Hotfix: clarify -python Fast DDS-Gen option #366

Merged

Conversation

JLBuenoLopez
Copy link
Contributor

This PR clarifies that:

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

…ther platforms different than Ubuntu are supported

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@swarm59
Copy link

swarm59 commented May 5, 2022

Thanks for your clarification.
Let me ask you for a possible related issue:
Is it possible in python to create Contentfilteredtopic, given that type object is not supported ?
Please note that when I try to create a Contentfilteredtopic with python files generated without the -typeobject flag, I achieve the following run time error:
2022-05-05 16:42:13.907 [DDSSQLFILTER Error] No TypeObject found for type VideoTrackerActivateMultiobjectTracking -> Function create_content_filter
2022-05-05 16:42:13.907 [PARTICIPANT Error] Could not create filter of class DDSSQL for expression "(A_referenceNum == %0) -> Function create_contentfilteredtopic
F
where "VideoTrackerActivateMultiobjectTracking" is the reference topic data type name.
Thanks for the support,
Francesco

@JLBuenoLopez
Copy link
Contributor Author

Hi @swarm59,

You are correct that the standard DDSSQL filter requires that the Type Object is defined in order to work. Otherwise the content filtered topic creation fails as you are seeing. And you are correct, ContentFilteredTopic feature is a really recent addition to Fast DDS library since release v2.5.1. It was being developed at the same time as the Python bindings (which was released almost at the same time), so this feature is still not supported in Fast DDS python bindings. That is the reason why the Fast DDS Python API reference does not include the corresponding section about ContentFilteredTopic. Nevertheless, I agree that the create_contentfilteredtopic python binding should return unsupported instead of failing trying to create the content filtered topic.

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit a19a01b into master May 9, 2022
@MiguelCompany MiguelCompany deleted the hotfix/fastddsgen-incompatible-typeobject-python branch May 9, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants