Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15628] XML configuration for Ownership QoS #403

Merged
merged 9 commits into from
Sep 28, 2022
Merged

[15628] XML configuration for Ownership QoS #403

merged 9 commits into from
Sep 28, 2022

Conversation

MRicoIE2CS
Copy link
Contributor

XML examples added to show the possibility of configuring ownership QoS policy from XML.
Related to Fast DDS PR: eProsima/Fast-DDS#2967.

@MRicoIE2CS
Refs #15628: XML code snippet.
a6dabc2 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS
Refs #15628: indentation.
259a14d 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS
Refs #15628: Adding XML snippets to show example of configuring owner…
c51e561 
…ship QoS.

Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS MRicoIE2CS mentioned this pull request Sep 22, 2022
Merged
10 tasks
jsan-rt
jsan-rt suggested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is actually only tangentially related to this PR. Now that we are modifying things related to ownership, we should clarify Ownership's behavior when two writers have the same strength. This is something that slipped past my Ownership review.

@MRicoIE2CS
Refs #15628: Explain case of same strengths
42e068e 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS
Copy link
Contributor Author

This comment is actually only tangentially related to this PR. Now that we are modifying things related to ownership, we should clarify Ownership's behavior when two writers have the same strength. This is something that slipped past my Ownership review.

Done: 42e068e Refs #15628: Explain case of same strengths

@MRicoIE2CS
Refs #15628: Nitpick
2ca357c 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
jsan-rt
jsan-rt previously approved these changes Sep 26, 2022
View reviewed changes
@MRicoIE2CS
Copy link
Contributor Author

I have seen that it lacks explanation on this chapter: https://fast-dds.docs.eprosima.com/en/latest/fastdds/xml_configuration/common.html#qos regarding ownership.
I am going to add it now.

@MRicoIE2CS
Refs #15628: Add ownership to XML/common/qos
023d003 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS
Refs #15628: XML snippet
468ada7 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MRicoIE2CS
Refs #15628: Fix links to api
34c385c 
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@EduPonz EduPonz added this to the v2.8.0 milestone Sep 28, 2022
@EduPonz
Refs #15628: Add Ownership to ToC
c631881 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz merged commit 32b5650 into master Sep 28, 2022
@EduPonz EduPonz deleted the feature/ownership_qos_XML branch September 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@jsan-rt jsan-rt jsan-rt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MRicoIE2CS @EduPonz @jsan-rt