Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16732] on_unacknowledged_sample_removed documentation #439

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

This PR includes documentation of the new DataWriterListener callback on_unacknowledged_sample_removed. It should be merged once the implementation has been done in Fast DDS.

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
…Tester

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor Author

CI should fail because the Fast DDS branch does not have the exact same name.
Here a manual CI job is run.

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

New manual CI here

@JLBuenoLopez
Copy link
Contributor Author

Another manual CI

@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Feb 8, 2023
@MiguelCompany MiguelCompany merged commit 57fa004 into master Feb 8, 2023
@MiguelCompany MiguelCompany deleted the feature/sample-removed-unacknowdleged branch February 8, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants