Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20508] TCP first message loss #699

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[20508] TCP first message loss #699

merged 2 commits into from
Mar 6, 2024

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Feb 29, 2024 •
edited by MiguelCompany
Loading

Description

With the related PR, the tcp_negotiation_timeout Transport Descriptor will be used to wait until logical port negotiation is finished prior sending data.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@jepemi
Refs #20508: Add wait_for_logical_port_negotiation_ms to transport de…
31a4804 
…scriptor

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi
Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout
de5706a 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi jepemi mentioned this pull request Feb 29, 2024
Merged
13 tasks
@EduPonz EduPonz added this to the v2.14.0 milestone Mar 1, 2024
@MiguelCompany
Copy link
Member

@richiprosima Please test docs

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@EduPonz EduPonz merged commit 05ebded into master Mar 6, 2024
4 checks passed
@EduPonz EduPonz deleted the bugfix/tcp_first_message_loss branch March 6, 2024 05:56
This was referenced Mar 15, 2024
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jepemi @MiguelCompany @EduPonz