Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21120] RTPS reader APIs refactor #791

Merged
merged 4 commits into from
Jun 11, 2024
Merged

[21120] RTPS reader APIs refactor #791

merged 4 commits into from
Jun 11, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 3, 2024 •
edited by EduPonz
Loading

Description

This PR adapts the code snippets using the RTPSReader API to the refactor on that interfaces.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jun 3, 2024
@MiguelCompany MiguelCompany mentioned this pull request Jun 3, 2024
Merged
9 tasks
@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 docs

@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 docs

@MiguelCompany
Refs #21120. Adapt to changes in RTPSReader.
8e03d2a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21120. Use expects_inline_qos in XML.
78acba2 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21120. Add method name to spelling wordlist.
9a7854d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21120. Snake case for ReaderTimes.
1f39e26 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@EduPonz
Copy link

EduPonz commented Jun 11, 2024

@richiprosima please test_3 docs

@EduPonz EduPonz merged commit ac2911b into master Jun 11, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21082/reader branch June 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz