Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21137] Adapt to RTPS WriterHistory refactor #826

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[21137] Adapt to RTPS WriterHistory refactor #826

merged 2 commits into from
Jun 27, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 26, 2024 •
edited by EduPonz
Loading

Description

This PR adapts the RTPS example code for the refactor in WriterHistory.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jun 26, 2024
@MiguelCompany MiguelCompany mentioned this pull request Jun 26, 2024
Merged
10 tasks
@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 docs

EduPonz
EduPonz suggested changes Jun 26, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT

code/CodeTester.cpp Outdated Show resolved Hide resolved
Base automatically changed from feature/21128 to master June 27, 2024 05:47
@MiguelCompany @EduPonz
Refs #21137. Adapt to RTPS WriterHistory refactor.
707789c 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21137. Spaces in comments.
4fa4893 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@EduPonz
Copy link

EduPonz commented Jun 27, 2024

@richiprosima Please test_3 docs

@EduPonz EduPonz merged commit fac26ea into master Jun 27, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21082/history branch June 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz