Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20903] Documentation to serialize DynamicData to JSON #844

Merged
merged 11 commits into from
Jul 11, 2024
Merged

[20903] Documentation to serialize DynamicData to JSON #844

merged 11 commits into from
Jul 11, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Jul 4, 2024 •
edited by EduPonz
Loading

Description

This PR provides the documentation for the json_serialize method implemented in eProsima/Fast-DDS#4780

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request Jul 4, 2024
Closed
8 tasks
@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Jul 5, 2024
Merged
13 tasks
juanlofer-eprosima
juanlofer-eprosima requested changes Jul 5, 2024
View reviewed changes
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
rsanchez15
rsanchez15 requested changes Jul 8, 2024
View reviewed changes
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
@LuciaEchevarria99 LuciaEchevarria99 added this to the v3.0.0 milestone Jul 9, 2024
rsanchez15
rsanchez15 requested changes Jul 9, 2024
View reviewed changes
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
rsanchez15
rsanchez15 previously approved these changes Jul 9, 2024
View reviewed changes
@LuciaEchevarria99
Documentation to serialize DynamicData to JSON
840729a 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Change section name and set JSON to not filled DynamicData
4ffef89 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Add Supported Types Serialization section and add more verbosity
b608eaa 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Add json_serialize API, references and change example
036e4c7 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Apply suggested changes
a1bdb66 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Fix spelling errors
2ec3d46 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Remove unnecessary idl
b00f2f1 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
rsanchez15
rsanchez15 previously approved these changes Jul 10, 2024
View reviewed changes
juanlofer-eprosima
juanlofer-eprosima requested changes Jul 10, 2024
View reviewed changes
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/type_serializing.rst Outdated Show resolved Hide resolved
@LuciaEchevarria99
Apply suggested changes
2fc2b88 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
juanlofer-eprosima
juanlofer-eprosima requested changes Jul 10, 2024
View reviewed changes
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
@LuciaEchevarria99
Add bitset section
5a2a78f 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Apply minor change
1a65ff9 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
rsanchez15
rsanchez15 requested changes Jul 10, 2024
View reviewed changes
code/json/Bitsets.json Outdated Show resolved Hide resolved
@LuciaEchevarria99
Add missing blank space in file
5f9e0c1 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
juanlofer-eprosima
juanlofer-eprosima approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOTM

@EduPonz EduPonz merged commit 2885461 into master Jul 11, 2024
4 checks passed
@EduPonz EduPonz deleted the v3.0/dynamic-data-json branch July 11, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LuciaEchevarria99 @rsanchez15 @juanlofer-eprosima @EduPonz