Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21320] Fix master references in stable version #855

Merged
merged 2 commits into from
Jul 9, 2024
Merged

[21320] Fix master references in stable version #855

merged 2 commits into from
Jul 9, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 9, 2024 •
edited by Mario-DL
Loading

Description

In Docs stable version (latest tag v2.14.2 - 2.14.x - 2.x versions), there were broken links.
This PR move those to 2.x reference so they are not broken anymore.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso
Refs #21320: Fix master references in stable version
bb4a2e0 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v2.14.3 milestone Jul 9, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 9, 2024
Mario-DL
Mario-DL reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may leverage this PR to address a couple of renamings:

  • Fast-RTPS-docs/master with Fast-DDS-docs/2.x
  • Fast-DDS-Gen/master with Fast-DDS-Gen/3.x

What do you think ?

@JesusPoderoso
Copy link
Contributor Author

What do you think ?

I agree, it is the perfect opportunity

@JesusPoderoso
Refs #21320: Apply Mario' suggestion
344e619 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Mario-DL
Mario-DL approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso merged commit f018cc8 into 2.14.x Jul 9, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/21320 branch July 9, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v2.14.3
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @Mario-DL