Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21295] Participant discovery data refactor #874

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[21295] Participant discovery data refactor #874

merged 1 commit into from
Jul 24, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR

  • Change the name of the enum DISCOVERY_STATUS → ParticipantDiscoveryStatus.
  • The methods on_participant_discover() now take ParticipantBuiltinTopicData and a ParticipantDiscoveryStatus, instead of ParticipantDiscoveryInfo.
  • Remove ParticipantDiscoveryInfo
  • Remove ParticipantProxyData
    according with the changes of the related implementation

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf elianalf added this to the v3.0.0 milestone Jul 16, 2024
@elianalf elianalf marked this pull request as ready for review July 16, 2024 14:24
@elianalf elianalf mentioned this pull request Jul 16, 2024
Merged
11 tasks
Base automatically changed from feature/21301 to master July 17, 2024 05:59
@MiguelCompany MiguelCompany force-pushed the participant_discovery_data_refactor branch from 2a8da72 to c14ab79 Compare July 19, 2024 09:09
MiguelCompany
MiguelCompany approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 19, 2024 09:43
@elianalf
Refs #21295: Refactor of Participant Discovery Structes
8398bc5 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the participant_discovery_data_refactor branch from c14ab79 to 8398bc5 Compare July 23, 2024 14:06
MiguelCompany
MiguelCompany approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit a496dcc into master Jul 24, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the participant_discovery_data_refactor branch July 24, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @MiguelCompany