Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21313] Type propagation policy #880

Merged
merged 2 commits into from
Jul 26, 2024
Merged

[21313] Type propagation policy #880

merged 2 commits into from
Jul 26, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 17, 2024 •
edited by MiguelCompany
Loading

Description

This PR is the Fast DDS Docs counterpart of

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 17, 2024
@EduPonz EduPonz mentioned this pull request Jul 17, 2024
Merged
12 tasks
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch from 3a4d09a to 2aa0f6d Compare July 19, 2024 11:11
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany July 20, 2024 04:55
@richiware richiware removed the request for review from MiguelCompany July 24, 2024 06:07
@richiware richiware force-pushed the feature/type_propagation_policy branch from 2aa0f6d to ad6d48c Compare July 24, 2024 06:08
MiguelCompany
MiguelCompany requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but CI is failing when processing doxygen references

@EduPonz
Refs #21313: Remove outdated note
991f563 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21313: Add type_propagation property documentation
ac34c16 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch from ad6d48c to ac34c16 Compare July 24, 2024 08:53
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany July 24, 2024 08:53
MiguelCompany
MiguelCompany approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit be9b755 into master Jul 26, 2024
4 of 7 checks passed
@EduPonz EduPonz deleted the feature/type_propagation_policy branch July 26, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @MiguelCompany