Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21443] Fix bug in initial peers documentation #896

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[21443] Fix bug in initial peers documentation #896

merged 2 commits into from
Sep 4, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Aug 19, 2024 •
edited
Loading

Description

This PR updates the inital peers documentation with the changes introduced in

Note: spelling issue (unknown word reachability) is fixed in the bump PR

Fixes eProsima/Fast-DDS/discussions/5153

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso
Refs #21443: Fix bug in initial peers documentation
5fe43a6 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v3.0.1 milestone Aug 19, 2024
@JesusPoderoso JesusPoderoso self-assigned this Aug 19, 2024
MiguelCompany
MiguelCompany requested changes Aug 19, 2024
View reviewed changes
docs/fastdds/discovery/simple.rst Outdated Show resolved Hide resolved
docs/fastdds/discovery/simple.rst Outdated Show resolved Hide resolved
@JesusPoderoso
Refs #21443: Apply rev suggestions
b465c20 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@MiguelCompany MiguelCompany self-requested a review August 19, 2024 09:30
MiguelCompany
MiguelCompany approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@rsanchez15 rsanchez15 merged commit 9e8a235 into master Sep 4, 2024
4 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/initial_peers_pdp branch September 4, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @MiguelCompany @rsanchez15