Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21818] Improve topic view #239

Merged
merged 7 commits into from
Nov 21, 2024
Merged

[21818] Improve topic view #239

merged 7 commits into from
Nov 21, 2024

Conversation

Carlosespicur
Copy link
Contributor

Main changes

  • DomainGraph shows more compact, intercalating topic tags
  • Added intercalated colors for Topic tags, topic bars and connection arrows .
  • Fixed tag size. Larger tag names are elided and a hover shows the complete name

This PR must be merged after:

qml/GraphConnection.qml Outdated Show resolved Hide resolved
qml/GraphConnection.qml Outdated Show resolved Hide resolved
qml/GraphConnection.qml Outdated Show resolved Hide resolved
@Carlosespicur Carlosespicur force-pushed the feature/improve-topic-view branch from cc0bf14 to b82a8e3 Compare November 20, 2024 11:34
@Carlosespicur Carlosespicur force-pushed the feature/improve-display-traceability branch from c893c60 to a5da79d Compare November 20, 2024 14:08
depink5
depink5 previously approved these changes Nov 20, 2024
Copy link

@depink5 depink5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI 🎉

Base automatically changed from feature/improve-display-traceability to main November 20, 2024 15:05
@rsanchez15 rsanchez15 dismissed depink5’s stale review November 20, 2024 15:05

The base branch was changed.

@depink5 depink5 self-requested a review November 20, 2024 15:49
depink5

This comment was marked as outdated.

Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The box for the topic name keep the maximum width restriction even if the graph is in the filter view. I'd remove this restriction in that case.

image

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/improve-topic-view branch from b82a8e3 to 457139f Compare November 20, 2024 16:28
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@rsanchez15 rsanchez15 merged commit d04bbdb into main Nov 21, 2024
14 checks passed
@rsanchez15 rsanchez15 deleted the feature/improve-topic-view branch November 21, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants