Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14848] Allow custom transports on init_monitor #160

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

MiguelCompany
Copy link
Member

Change the behavior of init_monitor so the transport list is only overridden when use_builtin_transports is true.

This allows users to set their own transport configuration on the XML.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany temporarily deployed to codecov June 13, 2022 07:27 Inactive
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #160 (3f6e8ce) into main (143f007) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   57.75%   57.73%   -0.02%     
==========================================
  Files          31       31              
  Lines        4329     4330       +1     
  Branches     2319     2320       +1     
==========================================
  Hits         2500     2500              
  Misses         60       60              
- Partials     1769     1770       +1     
Impacted Files Coverage Δ
src/cpp/StatisticsBackend.cpp 45.32% <25.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143f007...3f6e8ce. Read the comment docs.

@EduPonz EduPonz merged commit 52cd0f1 into main Jul 5, 2022
@EduPonz EduPonz deleted the hotfix/allow-custom-transports branch July 5, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants