Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dump and clean to example [15957] #176

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Add dump and clean to example [15957] #176

merged 5 commits into from
Oct 26, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 14, 2022 •
edited
Loading

@jparisu jparisu temporarily deployed to codecov October 14, 2022 05:53 Inactive
@jparisu jparisu marked this pull request as ready for review October 14, 2022 11:41
@jparisu jparisu mentioned this pull request Oct 17, 2022
Draft
@jparisu jparisu changed the title Add bump and clean to example Add bump and clean to example [15957] Oct 24, 2022
@jparisu jparisu temporarily deployed to codecov October 25, 2022 06:11 Inactive
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 58.42% // Head: 58.42% // No change to project coverage 👍

Coverage data is based on head (623fd9a) compared to base (a61388a).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   58.42%   58.42%           
=======================================
  Files          33       33           
  Lines        4421     4421           
  Branches     2352     2352           
=======================================
  Hits         2583     2583           
  Misses         54       54           
  Partials     1784     1784

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MiguelCompany
Copy link
Member

@jparisu Would you mind rebasing this one?

MiguelCompany
MiguelCompany previously approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but this should be rebased

Add bump and clean to example
3d1321d 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov October 26, 2022 14:08 Inactive
uncrustify
4e6c472 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov October 26, 2022 14:14 Inactive
MiguelCompany
MiguelCompany requested changes Oct 26, 2022
View reviewed changes
examples/cpp/HelloWorldExample/arg_configuration.h Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/Monitor.h Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/Monitor.h Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/Monitor.cpp Outdated Show resolved Hide resolved
apply suggestions
a3dcbed 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu changed the title Add bump and clean to example [15957] Add dump and clean to example [15957] Oct 26, 2022
MiguelCompany
MiguelCompany requested changes Oct 26, 2022
View reviewed changes
examples/cpp/HelloWorldExample/Monitor.cpp Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/Monitor.cpp Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/arg_configuration.h Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/arg_configuration.h Outdated Show resolved Hide resolved
examples/cpp/HelloWorldExample/main.cpp Outdated Show resolved Hide resolved
include/fastdds_statistics_backend/nlohmann-json/json.hpp Outdated Show resolved Hide resolved
apply suggestions
74803f5 
Signed-off-by: jparisu <javierparis@eprosima.com>
@MiguelCompany
Revert accidental change on json.hpp
623fd9a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany temporarily deployed to codecov October 26, 2022 17:36 Inactive
MiguelCompany
MiguelCompany approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 74f5197 into main Oct 26, 2022
@MiguelCompany MiguelCompany deleted the feature/advance-example branch October 26, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparisu @MiguelCompany