Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20511] Remove use of deprecated FindPythonInterp #4447

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[20511] Remove use of deprecated FindPythonInterp #4447

merged 1 commit into from
Feb 26, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 24, 2024 •
edited by JesusPoderoso
Loading

Description

FindPythonInterp has been deprecated since CMake 3.12. This PR finds the python interpreter within CMake files using the supported FindPython3. This change if motivated by the intention of supporting Ubuntu 24.04, that ships CMake 3.28.3, version in which a CMake warning about FindPythonInterp is shown; this warning was introduced in CMake 3.27.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #20511: Remove use of deprecated FindPythonInterp
e8c79ec 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.14.0 milestone Feb 24, 2024
This was referenced Feb 24, 2024
Merged
Merged
JesusPoderoso
JesusPoderoso approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link
Author

EduPonz commented Feb 26, 2024

@richiprosima please test this

@EduPonz EduPonz merged commit f46d383 into master Feb 26, 2024
10 of 17 checks passed
@EduPonz EduPonz deleted the refactor/cmake_find_python branch February 26, 2024 13:17
Mario-DL pushed a commit that referenced this pull request May 10, 2024
@EduPonz @Mario-DL
Remove use of deprecated FindPythonInterp (#4447)
53e6a79 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@Mario-DL Mario-DL mentioned this pull request May 10, 2024
Merged
8 tasks
Mario-DL pushed a commit that referenced this pull request May 10, 2024
@EduPonz @Mario-DL
Remove use of deprecated FindPythonInterp (#4447)
cf03ad0 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@Mario-DL Mario-DL mentioned this pull request May 10, 2024
Merged
8 tasks
Mario-DL pushed a commit that referenced this pull request May 10, 2024
@EduPonz @Mario-DL
Remove use of deprecated FindPythonInterp (#4447)
40f05a1 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@Mario-DL Mario-DL mentioned this pull request May 10, 2024
Merged
8 tasks
EduPonz added a commit that referenced this pull request May 13, 2024
@mergify @Mario-DL @EduPonz
Fix Python Installation version in Github CI. Address failing system …
8fd1914 
…tests environment issues (#4759) (#4764)

* Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759)

* Refs #20965: Install a fix python version in ubuntu and windows cis

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Decide Python environment depending on the version

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Add some comments

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 3b2e781)

* Remove use of deprecated FindPythonInterp (#4447)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request May 17, 2024
@EduPonz @MiguelCompany
Remove use of deprecated FindPythonInterp (#4447)
d897da7 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request May 17, 2024
@mergify @Mario-DL @EduPonz
Fix Python Installation version in Github CI. Address failing system …
d2f828a 
…tests environment issues. (#4759, #4447, #4770) (#4765)

* Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759)

* Refs #20965: Install a fix python version in ubuntu and windows cis

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Decide Python environment depending on the version

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Add some comments

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 3b2e781)

# Conflicts:
#	test/system/tools/fastdds/CMakeLists.txt

* Solve conflicts

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Remove use of deprecated FindPythonInterp (#4447)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Add missing Python3_executable communication test command

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Do not require PYTHON_VERSION to be defined in .bat files (#4770)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request May 20, 2024
@mergify @Mario-DL @EduPonz
Fix Python Installation version in Github CI. Address failing system …
5b509ca 
…tests environment issues (#4759) (#4766)

* Fix Python Installation version in Github CI. Address failing system tests environment issues (#4759)

* Refs #20965: Install a fix python version in ubuntu and windows cis

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Decide Python environment depending on the version

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Prevent Qt installation from setting up python in Ubuntu CI

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20965: Add some comments

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 3b2e781)

# Conflicts:
#	test/system/tools/fastdds/CMakeLists.txt

* Solve conflicts

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Remove use of deprecated FindPythonInterp (#4447)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Add missing Python3_executable communication test command

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Do not require PYTHON_VERSION to be defined in .bat files (#4770)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JesusPoderoso