Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20570] Fix warnings on tests on Windows 32bits #4494

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[20570] Fix warnings on tests on Windows 32bits #4494

merged 1 commit into from
Mar 4, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Mar 1, 2024 •
edited by JesusPoderoso
Loading

Description

This PR fixes warnings on tests when compiled in Windows 32-bits.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

JesusPoderoso
JesusPoderoso previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added this to the v2.14.0 milestone Mar 1, 2024
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Mar 1, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@richiware
Fix warnings on Windows 32bits
3422096 
Signed-off-by: Ricardo González <ricardo@richiware.dev>
@richiware richiware force-pushed the bugfix/win32-warnings-on-tests branch from 0336ab4 to 3422096 Compare March 4, 2024 08:30
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@EduPonz EduPonz changed the title Fix warnings on tests on Windows 32bits [20570] Fix warnings on tests on Windows 32bits Mar 4, 2024
JesusPoderoso
JesusPoderoso approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 4, 2024
@EduPonz EduPonz merged commit 043dd77 into master Mar 4, 2024
14 of 16 checks passed
@EduPonz EduPonz deleted the bugfix/win32-warnings-on-tests branch March 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @JesusPoderoso @EduPonz