-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21519] Fix issue with exclusive ownership and unordered samples (backport #5182) #5215
Conversation
Cherry-pick of b1a7fe2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ca71da2
to
a9df106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
a9df106
to
a4c4782
Compare
* Refs #20866. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20866. Additional regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20866. Fix issue. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20866. Fix unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20866. Refactor test to run several cases. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit b1a7fe2) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> # Conflicts: # test/unittest/dds/subscriber/DataReaderHistoryTests.cpp
a4c4782
to
33d6fe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Windows CI issue unrelated to the PR content. |
Description
During interoperability testing, some flakiness on Test_Ownership_3 unveiled that a reader with exclusive ownership and a
KEEP_ALL
history may return a mix of samples from writers with different strengths.This PR adds a regression test and fixes the issue by removing inappropriate samples during the take operation.
@Mergifyio backport 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5182 done by [Mergify](https://mergify.com).