-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22033] Release participant_stateless
secure builtin writer history change when authentication has finished
#5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mario-DL
changed the title
[22033] Release
[22033] Release Nov 6, 2024
participant_stateless
secure builtin writer when authentication has finishedparticipant_stateless
secure builtin writer history change when authentication has finished
Mario-DL
force-pushed
the
fix/22033
branch
2 times, most recently
from
November 7, 2024 12:32
2caa14e
to
8dbc8d2
Compare
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
November 7, 2024 12:33
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
… cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
November 8, 2024 08:10
MiguelCompany
approved these changes
Nov 11, 2024
Closed
1 task
Closed
1 task
@Mergifyio backport 3.1.x 3.0.x 2.14.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621)
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621)
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621)
This was referenced Nov 12, 2024
@Mergifyio backport 2.10.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621)
14 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not have reproducible environment anymore, but description and implementation loos good. thanks for letting me know.
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 14, 2024
…when authentication has finished (#5386) (#5391) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 14, 2024
…when authentication has finished (#5386) (#5392) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
cferreiragonz
pushed a commit
that referenced
this pull request
Nov 18, 2024
…when authentication has finished (#5386) (#5391) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 19, 2024
…when authentication has finished (#5386) (#5393) * Release `participant_stateless` secure builtin writer history change when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) * Update waitAuthorized in PubSub fastrtps_deprecated API Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Fix windows compilation error Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 4, 2024
…when authentication has finished (#5386) (#5394) * Release `participant_stateless` secure builtin writer history change when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) * Update waitAuthorized in PubSub fastrtps_deprecated API Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Fix windows compilation error Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SecurityManager
did not ensure thatparticipant_stateless_secure_writer
history changes were released when the remote participant was authenticated, leading to a high resource utilization.This PR:
participant stateless secure writer
history to remove the change whenparticipants cryptography
succeeds. In this way we ensure that authentication has finished in both sides. This was important because having authorized the remote is not a sufficient condition to remove the change as the remote may require us to resend until it completes the authentication with us.Addition Notes:
RTPSParticipantAllocationAttributes
.@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist