Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22101] Addres parseXMLMemberDynamicType regression #5499

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Dec 16, 2024

Description

This PR addresses a XML Dynamic type parser regression.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Dec 16, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima December 16, 2024 15:36
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 16, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@juanlofer-eprosima juanlofer-eprosima merged commit 0207274 into master Dec 19, 2024
16 of 17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the bugfix/22101 branch December 19, 2024 08:18
@Mario-DL
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x

Copy link
Contributor

mergify bot commented Dec 19, 2024

backport 3.1.x 3.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 19, 2024
* Refs #22484: Add test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22484: Fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 0207274)
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
* Refs #22484: Add test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #22484: Fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 0207274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants