[22210] Handle socket buffer size setting when system's maximum exceeded #5527

EugenioCollado · 2024-12-26T13:37:37Z

Description

This PR fixes the socket buffer size configuration mechanism. Previously, the try_setting_buffer_size method relied on the error code returned by the ASIO API to verify successful changes, which proved unreliable as no error code was returned even when the operation failed. The method has been updated to validate the buffer size by checking the actual size after setting the option, ensuring correct configuration or at least returning the actual final_buffer_value.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
NA: Any new/modified methods have been properly documented using Doxygen.
NA: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
NA: New feature has been added to the versions.md file (if applicable).
NA: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

…s::try_setting_buffer_size` Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

test/unittest/transport/AsioHelpersTests.cpp

test/unittest/transport/UDPv4Tests.cpp

test/unittest/transport/UDPv6Tests.cpp

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

MiguelCompany · 2025-01-10T09:17:11Z

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

mergify · 2025-01-10T09:17:25Z

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

#5560 [22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) has been created for branch 3.1.x
#5561 [22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) has been created for branch 3.0.x
#5562 [22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) has been created for branch 2.14.x
#5563 [22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) has been created for branch 2.10.x but encountered conflicts
#5564 [22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) has been created for branch 2.6.x but encountered conflicts

* Regression tests for asio_helpers socket buffer size Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Regression tests udp & tcp Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Refs #22210. Ensure that actual set value is returned by `asio_helpers::try_setting_buffer_size` Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix corner case infinite loop Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix UDP tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix windows compilation Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Applied suggestions to regression test Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Applied suggestions to udp tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5fc7786)

* Regression tests for asio_helpers socket buffer size Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Regression tests udp & tcp Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Refs #22210. Ensure that actual set value is returned by `asio_helpers::try_setting_buffer_size` Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix corner case infinite loop Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix UDP tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix windows compilation Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Applied suggestions to regression test Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Applied suggestions to udp tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5fc7786) # Conflicts: # test/unittest/transport/CMakeLists.txt

EugenioCollado and others added 4 commits December 26, 2024 12:57

Regression tests for asio_helpers socket buffer size

cd6fd8b

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Regression tests udp & tcp

e2eb4d3

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Refs #22210. Ensure that actual set value is returned by `asio_helper…

48a5964

…s::try_setting_buffer_size` Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Fix corner case infinite loop

61303f5

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado added this to the v3.2.0 milestone Dec 26, 2024

Uncrustify

3bb3d74

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado added the ci-pending PR which CI is running label Dec 26, 2024

EugenioCollado requested a review from MiguelCompany December 26, 2024 13:57

Fix UDP tests

4af02d6

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado requested a review from richiprosima December 27, 2024 09:37

Fix windows compilation

393bbdf

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado removed the request for review from richiprosima December 27, 2024 11:29

EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Dec 27, 2024

EugenioCollado requested a review from richiprosima December 27, 2024 11:30

EugenioCollado added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Dec 31, 2024

MiguelCompany requested changes Jan 3, 2025

View reviewed changes

test/unittest/transport/AsioHelpersTests.cpp Show resolved Hide resolved

test/unittest/transport/UDPv4Tests.cpp Outdated Show resolved Hide resolved

test/unittest/transport/UDPv6Tests.cpp Outdated Show resolved Hide resolved

EugenioCollado added 3 commits January 3, 2025 13:41

Applied suggestions to regression test

dea914f

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Applied suggestions to udp tests

fdc7416

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Uncrustify

39f613e

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

EugenioCollado requested review from richiprosima and removed request for richiprosima January 7, 2025 06:26

github-actions bot added the ci-pending PR which CI is running label Jan 7, 2025

MiguelCompany approved these changes Jan 10, 2025

View reviewed changes

EugenioCollado merged commit 5fc7786 into master Jan 10, 2025
17 checks passed

EugenioCollado deleted the bugfix/22210 branch January 10, 2025 09:17

This was referenced Jan 10, 2025

[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5560

Open

[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5561

Open

mergify bot mentioned this pull request Jan 10, 2025

[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5562

Open

12 tasks

This was referenced Jan 10, 2025

[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5563

Open

[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5564

Open

MiguelCompany mentioned this pull request Jan 10, 2025

[22208] The SocketTransportDescriptor::min_send_buffer_size() method returns too large value when exceeded net.core.wmem_max #4684

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22210] Handle socket buffer size setting when system's maximum exceeded #5527

[22210] Handle socket buffer size setting when system's maximum exceeded #5527

EugenioCollado commented Dec 26, 2024 •

edited by MiguelCompany

Loading

MiguelCompany commented Jan 10, 2025

mergify bot commented Jan 10, 2025 •

edited

Loading

[22210] Handle socket buffer size setting when system's maximum exceeded #5527

[22210] Handle socket buffer size setting when system's maximum exceeded #5527

Conversation

EugenioCollado commented Dec 26, 2024 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany commented Jan 10, 2025

mergify bot commented Jan 10, 2025 • edited Loading

✅ Backports have been created

EugenioCollado commented Dec 26, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Jan 10, 2025 •

edited

Loading