Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21053] Move DR TypeConsistencyEnforcement & DataRepresentation from TypeConsistency to DataReaderQos #137

Merged
merged 1 commit into from
May 27, 2024
Merged

[21053] Move DR TypeConsistencyEnforcement & DataRepresentation from TypeConsistency to DataReaderQos #137

merged 1 commit into from
May 27, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 23, 2024 •
edited by Mario-DL
Loading

Description

This PR updates the usage of DR qos DataRepresentation according to the changes introduced in:

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Changes do not break current interoperability.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone May 23, 2024
@JesusPoderoso
Copy link
Contributor Author

CI passed locally, it will not pass until Fast DDS PR is merged

Mario-DL
Mario-DL approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. We will wait for Fast DDS PR to be merged.

@JesusPoderoso
Refs #21053: Update DR qos datarepresentation
eaca8fe 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Mario-DL
Mario-DL approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 3761eb7 into master May 27, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21053 branch May 27, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @Mario-DL @EduPonz