Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21321] Update references to Time_t and Duration_t #165

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[21321] Update references to Time_t and Duration_t #165

merged 1 commit into from
Jul 23, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 15, 2024 •
edited by JesusPoderoso
Loading

Description

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • NO Changes do not break current interoperability.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jul 15, 2024
@Mario-DL Mario-DL mentioned this pull request Jul 15, 2024
Merged
12 tasks
@Mario-DL Mario-DL requested a review from EduPonz July 15, 2024 12:58
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 15, 2024
@Mario-DL
Refs #21321: Update references to Time_t and Duration_t
c2365c9 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for EduPonz July 22, 2024 13:38
JesusPoderoso
JesusPoderoso approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso removed the request for review from MiguelCompany July 22, 2024 15:16
@JesusPoderoso
Copy link
Contributor

Lets wait until this PR gets merged to rerun CI:

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2024
@MiguelCompany MiguelCompany merged commit d9fdd52 into master Jul 23, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/21321 branch July 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @JesusPoderoso @MiguelCompany