Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nightly builds to compile on Ubuntu 24 #112

Merged
merged 23 commits into from
Jul 15, 2024
Merged

Update nightly builds to compile on Ubuntu 24 #112

merged 23 commits into from
Jul 15, 2024

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 8, 2024 •
edited
Loading

Description

This PRs:

  • updates nightly builds to compile on Ubuntu 24.04,
  • removes nightly builds for Ubuntu 22.04, and
  • extends the action for installing python packages to setup a virtual environment,
  • adds a new Ubuntu action (setup_python_venv) for setting up a python virtual environment.

Contributor Checklist

  • Commit messages follow the company guidelines.
  • Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

rsanchez15 added 2 commits July 4, 2024 16:30
@rsanchez15
Add Ubuntu 24.04 and remove Ubuntu 22.04 to fastdds build
beae784 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update all actions to target current branch
5673dbc 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch from 8572c1f to 0ee7faf Compare July 8, 2024 09:20
@rsanchez15
Add python virtual env
15e75dc 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch 11 times, most recently from 5077ace to aa78f34 Compare July 8, 2024 10:32
@rsanchez15
Add setup_python_venv github action
14a4642 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch from aa78f34 to 14a4642 Compare July 8, 2024 10:33
@rsanchez15
Extract virtual env from action
82132a0 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch 4 times, most recently from de01df0 to 39b38c0 Compare July 8, 2024 10:44
@rsanchez15
Updagrade setup tools
ef37f15 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch 4 times, most recently from 965a77d to 247a64f Compare July 8, 2024 12:35
@rsanchez15
Add Ubuntu 24 CI to ddspipe and dev-utils builds
2558878 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the feature/ubuntu-24 branch from 247a64f to 2558878 Compare July 9, 2024 07:06
@rsanchez15
Update ddspipe build to Ubuntu 24
4d4477d 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 changed the title Feature/ubuntu 24 Update nightly builds to compile on Ubuntu 24 Jul 9, 2024
@rsanchez15
Restore references to main
8f4c8d0 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
irenebm
irenebm suggested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the README.md with the new artifact names and remove the outdated ones.

.github/workflows/configurations/metas/ubuntu-24.04/colcon.meta Outdated Show resolved Hide resolved
.github/workflows/build_dev_utils.yml Outdated Show resolved Hide resolved
@rsanchez15
Apply changes from review
8cf00d1 
Signed-off-by: Raúl <raul@eprosima.com>
irenebm
irenebm previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15
Temporal commit to test the actions in this branch
5d4a288 
Signed-off-by: Raúl <raul@eprosima.com>
@rsanchez15
Add inputs to setup_python_venv action
8036504 
Signed-off-by: Raúl <raul@eprosima.com>
@rsanchez15
Integrate setup python venv into install python packages action
36f48dc 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update README
67ec926 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Set action branches back to main
396b35c 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 requested a review from EduPonz July 15, 2024 09:36
@rsanchez15
Remove action for Windows OS
baf84f0 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
irenebm
irenebm previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15
Set python3 and pip3 explicitly in python action
cfdb576 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Set action branches back to current branch
f3c83e7 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Use pip module
69fad90 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update artifact names
8ed2bb4 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Set action branches back to main
99c72d2 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update versions.md
f18a4a4 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
EduPonz
EduPonz suggested changes Jul 15, 2024
View reviewed changes
versions.md Outdated Show resolved Hide resolved
versions.md Show resolved Hide resolved
@rsanchez15
Add new ubuntu action description to versions.md
f539eb4 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 merged commit b31bb51 into main Jul 15, 2024
1 check passed
@rsanchez15 rsanchez15 deleted the feature/ubuntu-24 branch July 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@irenebm irenebm irenebm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @EduPonz @irenebm