Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if python venv already exists in setup venv action #114

Merged
merged 7 commits into from
Jul 16, 2024

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 16, 2024

Description

Some jobs are failing due to copying the entire GitHub environment from one workflow to another. This causes the generated virtual environment to be also copied, and at the time of recreating it, since they do not have the same permissions, this action fails.

This PR updates the action of setting up the virtual environment to do it only in case it does not exist.

Contributor Checklist

  • Commit messages follow the company guidelines.
  • Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 force-pushed the hotfix/setup-python-venv branch from a2d1307 to 672012e Compare July 16, 2024 06:21
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update versions.md
  • Set action branches back to main
  • Update README.md with the new artifact names.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 5591e76 into main Jul 16, 2024
1 check passed
@rsanchez15 rsanchez15 deleted the hotfix/setup-python-venv branch July 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants