Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21226] Add skip_base input option to get_related_branch_from_repo action #118

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 26, 2024

Description

The get_releated_branch_from_repo action tries to find a branch with the same reference (name) in the given repo.
If fails, tries to get a branch with the same base name, else the given fallback branch.
We have already experience some issues with this actions, because it is used by eProsima products supported branches in nightly CI (for instance, lets say Fast DDS Gen 2.5.x), and instead of using the fallback of other product (Fast DDS 2.14.x), it finds a base branch in the repo that was not desired to be used (Fast DDS 2.5.x in this case).
This PR allows skipping the base branch step, so if the ref branch is not found, it uses directly the given fallback branch.

Contributor Checklist

  • Commit messages follow the company guidelines.
  • Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso self-assigned this Jul 26, 2024
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the action description to include information about the new option.

multiplatform/get_related_branch_from_repo/action.yml Outdated Show resolved Hide resolved
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the hotfix/get_related_branch_from_repo branch from 3847747 to a2cc02f Compare September 2, 2024 13:47
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso merged commit d9083fa into main Sep 2, 2024
1 check passed
@JesusPoderoso JesusPoderoso deleted the hotfix/get_related_branch_from_repo branch September 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants