Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21936] Fix Sphinx Docs action #128

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[21936] Fix Sphinx Docs action #128

merged 3 commits into from
Oct 15, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Oct 14, 2024 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

  • Commit messages follow the company guidelines.
  • Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

@JesusPoderoso JesusPoderoso self-assigned this Oct 14, 2024
@juanlofer-eprosima
Fix Sphinx Docs action
6af8ed7 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima
Change workspace default value in multiplatform colcon build action
2dcdf55 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
JesusPoderoso
JesusPoderoso previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima
Update versions.md
adaaaeb 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@JesusPoderoso JesusPoderoso merged commit 132c998 into main Oct 15, 2024
1 check passed
@JesusPoderoso JesusPoderoso deleted the hotfix/sphinx-docs-bug branch October 15, 2024 09:56
@juanlofer-eprosima juanlofer-eprosima changed the title Fix Sphinx Docs action [21936] Fix Sphinx Docs action Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanlofer-eprosima @JesusPoderoso