Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose test artifacts name to colcon-build-test action #96

Merged
merged 1 commit into from
May 20, 2024
Merged

Expose test artifacts name to colcon-build-test action #96

merged 1 commit into from
May 20, 2024

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented May 20, 2024 •
edited by JesusPoderoso
Loading

Description

This PR breaks API by changing the default name of the test artifacts to be unique.

Contributor Checklist

  • Commit messages follow the company guidelines.
  • ❌ Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

@rsanchez15
Expose test artifacts name to colcon-build-test action
3531956 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
JesusPoderoso
JesusPoderoso approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 1f04ef7 into main May 20, 2024
1 check passed
@rsanchez15 rsanchez15 deleted the feature/test-artifacts branch May 20, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanchez15 @JesusPoderoso